Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44782 )
Change subject: fw_config: Add caching to successfully probed fields ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44782/1/src/lib/fw_config.c File src/lib/fw_config.c:
https://review.coreboot.org/c/coreboot/+/44782/1/src/lib/fw_config.c@75 PS1, Line 75: #if ENV_RAMSTAGE
I didn't want to waste the space in bootblock, verstage and romstage (cache size is already 512 byte […]
If we switch to doing it in _init(), then we can stash pointers, and the cache size isn't as big of a deal.
https://review.coreboot.org/c/coreboot/+/44782/1/src/lib/fw_config.c@112 PS1, Line 112: match = true;
That's true, but when I wrote this, I intentionally did it this way for the manually called ones as […]
Although this does all become a lot simpler if it's just done in _init()... we can keep pointers and then the cache isn't a big deal for non-ramstage