Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35293 )
Change subject: mb/lenovo: Add ThinkPad R60 iGPU support ......................................................................
Patch Set 36:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35293/36//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35293/36//COMMIT_MSG@11 PS36, Line 11: -Some problem on 1400x1050 IPS display[1]. Works fine on Linux. That probably does not happen if you select a native resolution?
https://review.coreboot.org/c/coreboot/+/35293/36//COMMIT_MSG@15 PS36, Line 15: -Sometimes it takes 20s to boot to payload. take a look at timestamps with cbmem -t
https://review.coreboot.org/c/coreboot/+/35293/36//COMMIT_MSG@17 PS36, Line 17: : I want it to be in main coreboot tree for now, : and later work into making it into variant board. : I want to make it into variant board when it's merged. : Because I don't think it would be good to further convolute this patch. Adding it as a variant makes the review process easier, so that option should be preferred.
https://review.coreboot.org/c/coreboot/+/35293/36/Documentation/mainboard/le... File Documentation/mainboard/lenovo/r60.md:
https://review.coreboot.org/c/coreboot/+/35293/36/Documentation/mainboard/le... PS36, Line 13: -Libgfxinit libgfxinit does not support i945 and it's not used in this commit.