14 Mar
2020
14 Mar
'20
4:25 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39414 )
Change subject: nb/intel/pineview: Clean up code and comments ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39414/5/src/northbridge/intel/pinev... File src/northbridge/intel/pineview/early_init.c:
https://review.coreboot.org/c/coreboot/+/39414/5/src/northbridge/intel/pinev... PS5, Line 36: host_bridge
hmm, this is imho a bit too similar to HOST_BRIDGE
Well, it can be replaced with config of something, but it would change the binary. I'll leave the original name.
--
To view, visit https://review.coreboot.org/c/coreboot/+/39414
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29104b0c24d66c6f49844f99d62ec433bb31bdaf
Gerrit-Change-Number: 39414
Gerrit-PatchSet: 6
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 14 Mar 2020 23:25:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment