Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34615 )
Change subject: mb/google/hatch/variants: Set PsysPL2 and PL4 values
......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34615/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34615/2//COMMIT_MSG@9
PS2, Line 9: PsysPL2 to 70W and PL4 to 82W
How were these values calculated?
https://review.coreboot.org/c/coreboot/+/34615/2//COMMIT_MSG@9
PS2, Line 9: PL4 to 82W
Is this good to keep the device up when booting without battery?
https://review.coreboot.org/c/coreboot/+/34615/2//COMMIT_MSG@10
PS2, Line 10:
BUG=?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34615
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6a1f380547805d523a29c766903ffc6ba0023ac1
Gerrit-Change-Number: 34615
Gerrit-PatchSet: 2
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 29 Jul 2019 18:18:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment