29 Feb
2024
29 Feb
'24
11:19 a.m.
Attention is currently required from: Angel Pons, Arthur Heymans, Jérémy Compostella, Nick Vaccaro, Nico Huber, Shelley Chen, Tarun Tuli, Tim Wawrzynczak.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/67490?usp=email )
Change subject: gma: Update DP training with new fields ......................................................................
Patch Set 23:
(1 comment)
File common/ironlake/hw-gfx-gma-pch-dp.ads:
https://review.coreboot.org/c/libgfxinit/+/67490/comment/e9d2ed3c_d4ca4451 : PS19, Line 26: Reason => "Needed for a common interface"
@arthur@aheymans.xyz could you please share your thoughts on the above comment? […]
Could you please also help with "Verified+1" vote?
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/67490?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: I3f7f8a93408a74cfa29d1493a48c88ce73dc690c
Gerrit-Change-Number: 67490
Gerrit-PatchSet: 23
Gerrit-Owner: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Reviewer: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Tarun Tuli taruntuli@google.com
Gerrit-CC: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-CC: Shelley Chen shchen@google.com
Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Attention: Shelley Chen shchen@google.com
Gerrit-Attention: Tarun Tuli taruntuli@google.com
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Attention: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Nick Vaccaro nvaccaro@google.com
Gerrit-Comment-Date: Thu, 29 Feb 2024 11:19:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen shchen@google.com
Comment-In-Reply-To: Kapil Porwal kapilporwal@google.com
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment