Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Angel Pons, Yu-Ping Wu, Jianjun Wang.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62933 )
Change subject: soc/mediatek: Add timestamp to measure PERST# time
......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62933/comment/22dd4518_f9777714
PS1, Line 10:
Also paste the new log messages?
File src/soc/mediatek/common/pcie.c:
https://review.coreboot.org/c/coreboot/+/62933/comment/c5f74e05_7cd2c11a
PS1, Line 239: pre_timestamp, cur_timestamp, perst_time
Append unit us to the name, or is that clear? For example `perst_time_us`.
https://review.coreboot.org/c/coreboot/+/62933/comment/364af3d9_bc8cff5f
PS1, Line 245: [%lld]
Brackets not needed?
https://review.coreboot.org/c/coreboot/+/62933/comment/c2f40ac4_0689c98f
PS1, Line 255: [%lld]
Ditto.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62933
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie2b7b6174abdf951af5796ab5ed141c45f32fc71
Gerrit-Change-Number: 62933
Gerrit-PatchSet: 1
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Sat, 19 Mar 2022 09:08:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment