Matt DeVillier (matt.devillier@gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6002
-gerrit
commit f358ac6664d2810fc8654f3582209b02baa8f249 Author: Stefan Reinauer reinauer@chromium.org Date: Mon Jan 13 17:40:37 2014 -0800
google/panther: Avoid shutdown when thermal sensor is unavailable
When the thermal sensor on Panther is unavailable (early on resume) it will return 0x80 which causes our AML thermal code to overflow, which causes the system to shut down. Instead, return a reasonable value in those cases so that the system will continue running until the sensor gets back on its feet.
BUG=chrome-os-partner:24918 BRANCH=panther TEST=suspend_resume_test survived more than 100 iterations on Panther
Change-Id: Ib2d714c39d353ce2415361bc6590784a3f6837d2 Signed-off-by: Matt DeVillier matt.devillier@gmail.com Signed-off-by: Stefan Reinauer reinauer@google.com Reviewed-on: https://chromium-review.googlesource.com/182369 Tested-by: Stefan Reinauer reinauer@chromium.org Reviewed-by: Duncan Laurie dlaurie@chromium.org Commit-Queue: Stefan Reinauer reinauer@chromium.org --- src/mainboard/google/panther/acpi/thermal.asl | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/src/mainboard/google/panther/acpi/thermal.asl b/src/mainboard/google/panther/acpi/thermal.asl index a6ea851..7f02170 100644 --- a/src/mainboard/google/panther/acpi/thermal.asl +++ b/src/mainboard/google/panther/acpi/thermal.asl @@ -66,6 +66,11 @@ Scope (_TZ) // Get CPU Temperature from PECI via SuperIO TMPIN3 Store (_SB.PCI0.LPCB.SIO.ENVC.TIN3, Local0)
+ // Check for "no reading available + If (LEqual (Local0, 0x80)) { + Return (CTOK (\F2ON)) + } + // Check for invalid readings If (LOr (LEqual (Local0, 255), LEqual (Local0, 0))) { Return (CTOK (\F2ON))