Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49113 )
Change subject: ec/google/chromeec: Check AP reset cause for watchdog reset
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/49113/1/src/ec/google/chromeec/ec.c
File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/49113/1/src/ec/google/chromeec/ec.c...
PS1, Line 1006: resp.ap_resets_since_ec_boot
Given this comment here: https://chromium.googlesource. […]
Done
https://review.coreboot.org/c/coreboot/+/49113/1/src/ec/google/chromeec/ec_c...
File src/ec/google/chromeec/ec_commands.h:
PS1:
Yes please, we usually update ec_commands. […]
Done in CB:49196.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49113
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I761ecdd8811e5612b39e96c73442cc796361d0f0
Gerrit-Change-Number: 49113
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Nicolas Boichat
drinkcat@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nicolas Boichat
drinkcat@chromium.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-CC: Yilun Lin
yllin@google.com
Gerrit-Comment-Date: Thu, 07 Jan 2021 02:48:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Nicolas Boichat
drinkcat@chromium.org
Gerrit-MessageType: comment
