Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31905 )
Change subject: drivers/usb: Fix USB acpi gpio programming
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31905/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31905/2//COMMIT_MSG@8
PS2, Line 8:
: GPIO programming for transition between D0 and D3 state will require
: power resources to be present. Otherwise the previously defined
: "reset-gpio" can't take effect.
That is not the intention of the reset-gpio. […]
Hi Furquan,
That's the feedback from Amy as well, she did say the similar thing. Then how come the kernel driver can trigger the gpio pin, through "gpioio" resources?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31905
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If312150b5065e2e3fb362e9433cdeff47064a35a
Gerrit-Change-Number: 31905
Gerrit-PatchSet: 2
Gerrit-Owner: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Rajat Jain
rajatja@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 15 Mar 2019 08:14:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment