Attention is currently required from: Shelley Chen, Ravi kumar, Paul Menzel, mturney mturney, Julius Werner, Rajesh Patil. Sudheer Amrabadi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50581 )
Change subject: mb/google/herobrine: Initialize SPI FW for EC and TPM ......................................................................
Patch Set 93:
(8 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50581/comment/a47c39e2_814f7edc PS71, Line 11:
Please mention the two variants, and what is done with them.
Ack
Commit Message:
https://review.coreboot.org/c/coreboot/+/50581/comment/4a0198b7_a666aaff PS72, Line 7: mb/mainboard/herobrine
mb/google/herobrine
Ack
Patchset:
PS93: will be part of next patch train
File src/mainboard/google/herobrine/Kconfig:
https://review.coreboot.org/c/coreboot/+/50581/comment/b6959680_41670fb5 PS79, Line 27: BOARD_GOOGLE_PIGLIN
|| BOARD_GOOGLE_HOGLIN
Ack
https://review.coreboot.org/c/coreboot/+/50581/comment/1b8509d4_f4920530 PS79, Line 67: BOARD_GOOGLE_PIGLIN
|| BOARD_GOOGLE_HOGLIN
Ack
https://review.coreboot.org/c/coreboot/+/50581/comment/a2e3e4cf_6af87b48 PS79, Line 72: BOARD_GOOGLE_PIGLIN
|| BOARD_GOOGLE_HOGLIN
Ack
File src/mainboard/google/herobrine/bootblock.c:
https://review.coreboot.org/c/coreboot/+/50581/comment/669850e3_40bf9b6b PS79, Line 16: if (CONFIG(BOARD_GOOGLE_PIGLIN))
|| CONFIG(BOARD_GOOGLE_HOGLIN)
Ack
https://review.coreboot.org/c/coreboot/+/50581/comment/97f55a02_03f35a40 PS79, Line 17: qup_spi_init(CONFIG_DRIVER_TPM_SPI_BUS, 1010 * KHz);
Please add "/* H1/TPM SPI */" comment.
Ack