Attention is currently required from: Martin Roth, Andy Pont, Stefan Reinauer. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61550 )
Change subject: payloads/tianocore: Rework Makefile ......................................................................
Patch Set 8:
(6 comments)
File payloads/external/tianocore/Kconfig:
https://review.coreboot.org/c/coreboot/+/61550/comment/f04cc42f_4803b270 PS8, Line 9: config TIANOCORE_REPOSITORY : string "URL to git repository for edk2" : default "https://github.com/tianocore/edk2" if TIANOCORE_UPSTREAM : default "https://github.com/mrchromebox/edk2"
I think this should default to "https://review.coreboot. […]
I would agree - but in the future as coreboot's fork hasn't really got anything useful in it. I'm in the process of cleaning/re-writing/upstreaming the edk2 patches, it's slow going, hopefully in a month or so I can propose to reset coreboot's fork to upstream.
https://review.coreboot.org/c/coreboot/+/61550/comment/a5c95d2c_6f522921 PS8, Line 14: TIANOCORE_TAG
since this doesn't need to be a tag, maybe TIANOCORE_TAG_OR_REV ?
Done
https://review.coreboot.org/c/coreboot/+/61550/comment/612f694d_a11e13f8 PS8, Line 82: Disabling this option, which will reserve memory above 4G,
I think this could be phrased better - Though it's probable that nobody will misunderstand, It seems […]
Done
https://review.coreboot.org/c/coreboot/+/61550/comment/d31ebcee_49578813 PS8, Line 128: without an internal
with an external display?
Done
https://review.coreboot.org/c/coreboot/+/61550/comment/d94cc41b_a4f1c733 PS8, Line 136: by ~220KB.
This will probably change in the future, so maybe say something like "as of Jan 2022, this increases […]
I've changed it as it's wrong - Matt's branch is hardcoded to 0x800000 and nothing you do will get close to that limit. The tidied patch adds 0x10000 as that's all that is needed.
File payloads/external/tianocore/Makefile:
https://review.coreboot.org/c/coreboot/+/61550/comment/c99d80a0_72c16e8b PS8, Line 26: -D A
Nit: I think we usually prefer to have -D options without the space. […]
Ack