Attention is currently required from: Dolan Liu.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81776?usp=email )
Change subject: driver/i2c/rt5645: add RT5645 codec driver ......................................................................
Patch Set 1:
(9 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81776/comment/2c8039d8_29a9f4e9 : PS1, Line 2: Dolan Use Dolan Liu?
$ git config --global user.name "Dolan Liu" $ git commmit --amend -s --author="Dolan Liu liuyong5@huaqin.corp-partner.google.com"
https://review.coreboot.org/c/coreboot/+/81776/comment/d94ab984_50b80c1c : PS1, Line 9: Add rt5645 codec support. Please summarize the features of the RT5645, and mention the datasheet name and revision.
https://review.coreboot.org/c/coreboot/+/81776/comment/356cdbb6_2a8a9e53 : PS1, Line 13: Test: Test on anraggar, RT5645 driver can probe properly TEST=Successfully probe RT5645 on anraggar, and notice the log line: …
https://review.coreboot.org/c/coreboot/+/81776/comment/ab5a8787_7e093c0d : PS1, Line 14: Change-Id: I23407b451c728fb0cfad813552afc6d24e95608a Missing Signed-off-by Line.
File src/drivers/i2c/rt5645/rt5645.c:
https://review.coreboot.org/c/coreboot/+/81776/comment/f4ab6437_28f34110 : PS1, Line 32: int hp_mic_index = -1, irq_gpio_index = -1, hp_detect_index=-1;
`spaces required around that '=' (ctx:VxO)`
Please fix.
https://review.coreboot.org/c/coreboot/+/81776/comment/f654bfdc_c774ee5d : PS1, Line 91: if (config->hp_mic.pin_count)
`trailing whitespace`
Please fix.
https://review.coreboot.org/c/coreboot/+/81776/comment/1f257ab7_eee75c2f : PS1, Line 92: acpi_dp_add_gpio(dp, "hp-mic-gpios", path, hp_mic_index, 0, config->hp_mic.active_low); Indent?
https://review.coreboot.org/c/coreboot/+/81776/comment/fbaa2679_b80917de : PS1, Line 93: if (config->hp_detect.pin_count) What is the scope?
https://review.coreboot.org/c/coreboot/+/81776/comment/02753ff4_05709823 : PS1, Line 129: .name="ASoC RT5645 Codec driver",
`spaces required around that '=' (ctx:VxV)`
Please fix.