[coreboot-gerrit] Change in coreboot[master]: soc/intel: Expand SA_DEV_ROOT for ramstage

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34411 )

Change subject: soc/intel: Expand SA_DEV_ROOT for ramstage
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34411/2/src/soc/intel/skylake/inclu... 
File src/soc/intel/skylake/include/soc/pci_devs.h:

https://review.coreboot.org/c/coreboot/+/34411/2/src/soc/intel/skylake/inclu... 
PS2, Line 35: SA_DEV_ROOT
> Still used pre-ram, maybe smm.

I see.
> I just realised we have smm-y += DEVICETREE_STATIC_C. How is that supposed to work? In ramstage, devicetree is mutable so smm only gets the outdated data.

Yes, smm can only rely on the config data. Not anything that can dynamically change in ramstage.