[coreboot-gerrit] [M] Change in coreboot[main]: soc/intel: Add check to pmc_/gpe0_different_values

[Subrata Banik (Code Review)]

Attention is currently required from: Eran Mitrani, Intel coreboot Reviewers, Jakub Czapiga, Jayvik Desai, Jérémy Compostella, Matt DeVillier, Nick Vaccaro, Pranava Y N, Tarun, Werner Zeh.

Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86164?usp=email )

Change subject: soc/intel: Add check to pmc_/gpe0_different_values
......................................................................

Patch Set 2:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/86164/comment/4c3446e9_375f708e?usp... :
PS2, Line 14: This prevents potential issues arising from a zeroed configuration
> > Both the commit message and the code are wrong to me then.
>
> agreed
> > But according to the `TEST` flag in the commit message, it seems that this CL is helping. How is it possible ?
>
> good question - I've not yet tested it myself

acknowledged, looks like i have build for a platform without using zero value to case this scenario (therefore no assertion).

```
    /* Check if all values are different AND not all zero */
    bool result = (config->pmc_gpe0_dw0 != config->pmc_gpe0_dw1) &&
    		 (config->pmc_gpe0_dw0 != config->pmc_gpe0_dw2) &&
    		 (config->pmc_gpe0_dw1 != config->pmc_gpe0_dw2) ||
    		 all_zero;
```