EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48114 )
Change subject: mb/google/brya: Enable EC ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48114/3/src/mainboard/google/brya/v... File src/mainboard/google/brya/variants/baseboard/include/baseboard/ec.h:
https://review.coreboot.org/c/coreboot/+/48114/3/src/mainboard/google/brya/v... PS3, Line 14: EC_HOST_EVENT_MASK(EC_HOST_EVENT_AC_DISCONNECTED) |\
Just an FYI, this is fine for now, but we may remove this from some states later.
Noted. But why? Shouldn't notify host for AC disconnect?
https://review.coreboot.org/c/coreboot/+/48114/3/src/mainboard/google/brya/v... PS3, Line 64:
`#define EC_ENABLE_KEYBOARD_BACKLIGHT`
Done