2 Jan
2020
2 Jan
'20
7:52 p.m.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36444 )
Change subject: device/Kconfig: hide display menu when NO_GFX_INIT is selected ......................................................................
Patch Set 8:
Patch Set 8:
Have been away too long from this and now I'm totally puzzled. Maybe it's just a stale commit message? It seems this patch doesn't hide the menu because that is already done. It just makes sure that one can't select HAVE_* by accident, right?
Hmm, I just tested this again without this patch and indeed, the display menu is hidden. That wasn't the case before cb:35726.
I updated the commit msg since this is still useful
--
To view, visit https://review.coreboot.org/c/coreboot/+/36444
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec5a47f84b8c776a45edc6f4b31a03b9ac714b4e
Gerrit-Change-Number: 36444
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 02 Jan 2020 18:52:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment