[coreboot-gerrit] Change in coreboot[master]: mb/google/dedede/var/drawcia: change LTE reset pin to GPP_H17

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/57204 )

Change subject: mb/google/dedede/var/drawcia: change LTE reset pin to GPP_H17
......................................................................

mb/google/dedede/var/drawcia: change LTE reset pin to GPP_H17

Drawper change LTE reset pin from GPP_H0 to GPP_H17 from DVT phase.

BUG=b:198117092
TEST=emerge-dedede coreboot

Signed-off-by: Wisley Chen 
Change-Id: Ib65580babf7d21535df2bd8d33bb19261bebfe15
Reviewed-on: https://review.coreboot.org/c/coreboot/+/57204
Tested-by: build bot (Jenkins) 
Reviewed-by: Karthik Ramasubramanian 
Reviewed-by: Henry Sun 
---
M src/mainboard/google/dedede/variants/drawcia/gpio.c
M src/mainboard/google/dedede/variants/drawcia/ramstage.c
M src/mainboard/google/dedede/variants/drawcia/variant.c
3 files changed, 13 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Karthik Ramasubramanian: Looks good to me, approved
  Henry Sun: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/dedede/variants/drawcia/gpio.c b/src/mainboard/google/dedede/variants/drawcia/gpio.c
index 955d9a0..97865474 100644
--- a/src/mainboard/google/dedede/variants/drawcia/gpio.c
+++ b/src/mainboard/google/dedede/variants/drawcia/gpio.c
@@ -31,6 +31,7 @@

/* H0 : WWAN_PERST */
    PAD_CFG_GPO(GPP_H0, 0, PLTRST),
+	PAD_CFG_GPO(GPP_H17, 0, PLTRST),
 };

static const struct pad_config lte_disable_pads[] = {
@@ -38,6 +39,7 @@
    PAD_NC(GPP_B7, NONE),
    PAD_NC(GPP_D0, NONE),
    PAD_NC(GPP_H0, NONE),
+	PAD_NC(GPP_H17, NONE),
 };

const struct pad_config *variant_override_gpio_table(size_t *num)
diff --git a/src/mainboard/google/dedede/variants/drawcia/ramstage.c b/src/mainboard/google/dedede/variants/drawcia/ramstage.c
index 5acc033..2500b96 100644
--- a/src/mainboard/google/dedede/variants/drawcia/ramstage.c
+++ b/src/mainboard/google/dedede/variants/drawcia/ramstage.c
@@ -1,11 +1,20 @@
 /* SPDX-License-Identifier: GPL-2.0-or-later */

#include <baseboard/variants.h>
+#include <boardid.h>

static struct acpi_gpio lte_reset_gpio = ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H0);
 static struct acpi_gpio lte_enable_gpio = ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A10);
+/* New lte reset for drapwer DVT*/
+static struct acpi_gpio lte_new_reset_gpio =  ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H17);

void variant_devtree_update(void)
 {
-	update_lte_device(&lte_reset_gpio, &lte_enable_gpio);
+
+	uint32_t board_version = board_id();
+
+	if (board_version <= 9) /* board version 9 is drawper EVT */
+		update_lte_device(&lte_reset_gpio, &lte_enable_gpio);
+	else
+		update_lte_device(&lte_new_reset_gpio, &lte_enable_gpio);
 }
diff --git a/src/mainboard/google/dedede/variants/drawcia/variant.c b/src/mainboard/google/dedede/variants/drawcia/variant.c
index c557fe0..a8ec581 100644
--- a/src/mainboard/google/dedede/variants/drawcia/variant.c
+++ b/src/mainboard/google/dedede/variants/drawcia/variant.c
@@ -29,6 +29,7 @@
 static void power_off_lte_module(void)
 {
    gpio_output(GPP_H0, 0);
+	gpio_output(GPP_H17, 0);
    mdelay(20);
    gpio_output(GPP_A10, 0);
 }