EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37794 )
Change subject: soc/intel/cannonlake: Pass GPIO PM configuration devicetree.cb to ASL
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37794/2/src/soc/intel/cannonlake/gp...
File src/soc/intel/cannonlake/gpio_common.c:
https://review.coreboot.org/c/coreboot/+/37794/2/src/soc/intel/cannonlake/gp...
PS2, Line 28: memset(misccfg_pm_values, MISCCFG_ENABLE_GPIO_PM_CONFIG,
did we discussed to not override ? i don't recall. […]
OH, I thought Furquan mean let coreboot set the PM bits instead of FSP-S.If so, we don't care the overwrite anymore.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37794
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I75246be01aa4ab4cfa1e184ab6a11b718471995e
Gerrit-Change-Number: 37794
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 21 Dec 2019 13:44:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment