20 Feb
2020
20 Feb
'20
1:38 a.m.
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37991 )
Change subject: Doc/acpi: Add rfkill device specification ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37991/4/Documentation/acpi/rfkill.m... File Documentation/acpi/rfkill.md:
https://review.coreboot.org/c/coreboot/+/37991/4/Documentation/acpi/rfkill.m... PS4, Line 21: implement the following ACPI methods It might make sense to use a DSM with functions instead of hardcoded method names. It makes for less readable ACPI code (easier to generate) but perhaps a more flexible implementation.
--
To view, visit https://review.coreboot.org/c/coreboot/+/37991
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I94dc058825cb147aca0d007d68885d4bfbe580a8
Gerrit-Change-Number: 37991
Gerrit-PatchSet: 4
Gerrit-Owner: Matthew Garrett mjg59@google.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Matthew Garrett mjg59@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Matthew Garrett mjgarrett59@googlemail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 20 Feb 2020 01:38:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment