Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44205 )
Change subject: soc/intel/{cnl,icl,jsl,tgl}: Use Bus Master for setting up PWRMBASE
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44205/2/src/soc/intel/cannonlake/bo...
File src/soc/intel/cannonlake/bootblock/pch.c:
https://review.coreboot.org/c/coreboot/+/44205/2/src/soc/intel/cannonlake/bo...
PS2, Line 75: (char *)
void *?
https://review.coreboot.org/c/coreboot/+/44205/2/src/soc/intel/tigerlake/boo...
File src/soc/intel/tigerlake/bootblock/pch.c:
https://review.coreboot.org/c/coreboot/+/44205/2/src/soc/intel/tigerlake/boo...
PS2, Line 50: soc_config_pwrmbase
Looks like this is a good candidate to move to common/block/pmc?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44205
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7a148c718d7d2b618ad6e33d6cec11bd0bce0937
Gerrit-Change-Number: 44205
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 06 Aug 2020 01:48:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment