HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39615 )
Change subject: sc7180: Add display hardware pipe line initialization [patch 3 of 3] ......................................................................
Patch Set 16:
(3 comments)
Please include only what you use.
https://review.coreboot.org/c/coreboot/+/39615/16/src/mainboard/google/trogd... File src/mainboard/google/trogdor/mainboard.c:
https://review.coreboot.org/c/coreboot/+/39615/16/src/mainboard/google/trogd... PS16, Line 7: #include <device/i2c_simple.h> : #include <soc/display/msm_panel.h> : #include <soc/display.h> : #include <soc/qupv3_i2c.h> please, clean up
https://review.coreboot.org/c/coreboot/+/39615/16/src/soc/qualcomm/common/sn... File src/soc/qualcomm/common/sn65dsi86bridge.c:
https://review.coreboot.org/c/coreboot/+/39615/16/src/soc/qualcomm/common/sn... PS16, Line 16: #include <device/mmio.h> : #include <console/console.h> : #include <delay.h> : #include <device/device.h> : #include <device/i2c_simple.h> : #include <edid.h> : #include <string.h> : #include <timer.h> : #include <types.h> : #include <soc/addressmap.h> : #include <soc/display/msm_panel.h> : #include <soc/display.h> : #include <soc/sn65dsi86bridge.h> clean please
https://review.coreboot.org/c/coreboot/+/39615/16/src/soc/qualcomm/sc7180/di... File src/soc/qualcomm/sc7180/display.c:
https://review.coreboot.org/c/coreboot/+/39615/16/src/soc/qualcomm/sc7180/di... PS16, Line 16: #include <stdlib.h> : #include <console/console.h> : #include <delay.h> : #include <device/device.h> : #include <device/i2c_simple.h> : #include <soc/display/mdssreg.h> : #include <soc/display/mipi_dsi.h> : #include <soc/display/panel.h> : #include <soc/display/msm_panel.h> : #include <soc/display/panel_display.h> : #include <soc/display/target_sc7180.h> : #include <soc/display.h> : #include <soc/sn65dsi86bridge.h> same
please clean also the other files