Edward O'Callaghan (eocallaghan@alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6149
-gerrit
commit c7febc94eb0f974802e50510aa1c34e7e89ccdd6 Author: Edward O'Callaghan eocallaghan@alterapraxis.com Date: Sat Jun 28 17:52:34 2014 +1000
northbridge/amd: Remove some extraneous parentheses from if-statements
Spotted by Clang.
Change-Id: I38832da7b93d4ee18b8de3e80dc39513a8910221 Signed-off-by: Edward O'Callaghan eocallaghan@alterapraxis.com --- src/northbridge/amd/agesa/family10/northbridge.c | 2 +- src/northbridge/amd/agesa/family12/amdfam12_conf.c | 4 ++-- src/northbridge/amd/agesa/family14/amdfam14_conf.c | 4 ++-- src/northbridge/amd/amdfam10/conf.c | 7 ++----- 4 files changed, 7 insertions(+), 10 deletions(-)
diff --git a/src/northbridge/amd/agesa/family10/northbridge.c b/src/northbridge/amd/agesa/family10/northbridge.c index 886d112..78404ee 100644 --- a/src/northbridge/amd/agesa/family10/northbridge.c +++ b/src/northbridge/amd/agesa/family10/northbridge.c @@ -191,7 +191,7 @@ static u32 get_mmio_addr_index(u32 nodeid, u32 linkn) u32 index;
for (index=0; index<64; index++) { - if ((sysconf.conf_mmio_addrx[index+8] == 0)) { + if (sysconf.conf_mmio_addrx[index+8] == 0) { sysconf.conf_mmio_addr[index+8] = (nodeid & 0x3f) ; sysconf.conf_mmio_addrx[index+8] = 1 | ((linkn & 0x7)<<4); return index; diff --git a/src/northbridge/amd/agesa/family12/amdfam12_conf.c b/src/northbridge/amd/agesa/family12/amdfam12_conf.c index eb539d6..00ff641 100644 --- a/src/northbridge/amd/agesa/family12/amdfam12_conf.c +++ b/src/northbridge/amd/agesa/family12/amdfam12_conf.c @@ -195,7 +195,7 @@ static u32 get_io_addr_index(u32 nodeid, u32 linkn) u32 index;
for(index=0; index<256; index++) { - if((sysconf.conf_io_addrx[index+4] == 0)){ + if(sysconf.conf_io_addrx[index+4] == 0) { sysconf.conf_io_addr[index+4] = (nodeid & 0x3f) ; sysconf.conf_io_addrx[index+4] = 1 | ((linkn & 0x7)<<4); return index; @@ -211,7 +211,7 @@ static u32 get_mmio_addr_index(u32 nodeid, u32 linkn) u32 index;
for(index=0; index<64; index++) { - if((sysconf.conf_mmio_addrx[index+8] == 0)){ + if(sysconf.conf_mmio_addrx[index+8] == 0) { sysconf.conf_mmio_addr[index+8] = (nodeid & 0x3f) ; sysconf.conf_mmio_addrx[index+8] = 1 | ((linkn & 0x7)<<4); return index; diff --git a/src/northbridge/amd/agesa/family14/amdfam14_conf.c b/src/northbridge/amd/agesa/family14/amdfam14_conf.c index d302db3..c255213 100644 --- a/src/northbridge/amd/agesa/family14/amdfam14_conf.c +++ b/src/northbridge/amd/agesa/family14/amdfam14_conf.c @@ -195,7 +195,7 @@ static u32 get_io_addr_index(u32 nodeid, u32 linkn) u32 index;
for(index=0; index<256; index++) { - if((sysconf.conf_io_addrx[index+4] == 0)){ + if(sysconf.conf_io_addrx[index+4] == 0) { sysconf.conf_io_addr[index+4] = (nodeid & 0x3f) ; sysconf.conf_io_addrx[index+4] = 1 | ((linkn & 0x7)<<4); return index; @@ -211,7 +211,7 @@ static u32 get_mmio_addr_index(u32 nodeid, u32 linkn) u32 index;
for(index=0; index<64; index++) { - if((sysconf.conf_mmio_addrx[index+8] == 0)){ + if(sysconf.conf_mmio_addrx[index+8] == 0) { sysconf.conf_mmio_addr[index+8] = (nodeid & 0x3f) ; sysconf.conf_mmio_addrx[index+8] = 1 | ((linkn & 0x7)<<4); return index; diff --git a/src/northbridge/amd/amdfam10/conf.c b/src/northbridge/amd/amdfam10/conf.c index cfb914a..971e319 100644 --- a/src/northbridge/amd/amdfam10/conf.c +++ b/src/northbridge/amd/amdfam10/conf.c @@ -689,7 +689,7 @@ static u32 get_io_addr_index(u32 nodeid, u32 linkn) u32 index;
for(index=0; index<256; index++) { - if((sysconf.conf_io_addrx[index+4] == 0)){ + if(sysconf.conf_io_addrx[index+4] == 0) { sysconf.conf_io_addr[index+4] = (nodeid & 0x3f) ; sysconf.conf_io_addrx[index+4] = 1 | ((linkn & 0x7)<<4); return index; @@ -697,16 +697,14 @@ static u32 get_io_addr_index(u32 nodeid, u32 linkn) }
return 0; - }
static u32 get_mmio_addr_index(u32 nodeid, u32 linkn) { u32 index;
- for(index=0; index<64; index++) { - if((sysconf.conf_mmio_addrx[index+8] == 0)){ + if(sysconf.conf_mmio_addrx[index+8] == 0) { sysconf.conf_mmio_addr[index+8] = (nodeid & 0x3f) ; sysconf.conf_mmio_addrx[index+8] = 1 | ((linkn & 0x7)<<4); return index; @@ -714,7 +712,6 @@ static u32 get_mmio_addr_index(u32 nodeid, u32 linkn) }
return 0; - }
static void store_conf_io_addr(u32 nodeid, u32 linkn, u32 reg, u32 index,