28 May
2019
28 May
'19
6:05 p.m.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32989 )
Change subject: mb/pcengines/apu2: Describe serial ports in ACPI ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/32989/3/src/mainboard/pcengines/apu2/acpi/su... File src/mainboard/pcengines/apu2/acpi/superio.asl:
https://review.coreboot.org/#/c/32989/3/src/mainboard/pcengines/apu2/acpi/su... PS3, Line 19: I
usually that's part of the superio directory and you just include asl code here
For the Nuvoton NCT5104D there is no ASL code. Should I just import generic PNP UART with proper defines?
--
To view, visit https://review.coreboot.org/c/coreboot/+/32989
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0de4172a1884abbe9d625060a9045c9d71469e27
Gerrit-Change-Number: 32989
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com
Gerrit-CC: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Tue, 28 May 2019 16:05:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org
Gerrit-MessageType: comment