Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42730 )
Change subject: trogdor: Add board variant checks in Kconfig
......................................................................
Patch Set 4:
(1 comment)
Please remember to mark comments as resolved when you resolve them.
https://review.coreboot.org/c/coreboot/+/42730/1/src/mainboard/google/trogdo...
File src/mainboard/google/trogdor/Kconfig:
https://review.coreboot.org/c/coreboot/+/42730/1/src/mainboard/google/trogdo...
PS1, Line 8: def_bool y if BOARD_GOOGLE_TROGDOR
Please change the whole thing to […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42730
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ad413ea6e658e939796bebdff8c1e0dd76417cc
Gerrit-Change-Number: 42730
Gerrit-PatchSet: 4
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Manideep Kurumella
mkurumel@qualcomm.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Mon, 06 Jul 2020 23:53:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment