Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45811 )
Change subject: mb/google/kukui: Support SKU from camera EEPROM ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45811/2/src/mainboard/google/kukui/... File src/mainboard/google/kukui/boardid.c:
https://review.coreboot.org/c/coreboot/+/45811/2/src/mainboard/google/kukui/... PS2, Line 142: check_cros_camera_info this is defined in chromeos/Makefile.inc, which will be processed only by rule subdirs-$(CONFIG_CHROMEOS) += chromeos
So we can only invoke this function when CONFIG_CHROMEOS is set.
Can you try if add a
if (!CONFIG(CHROMEOS)) return 0;
In the beginning of this file and see if compiler optimization would skip linking check_cros_camera_info?
Otherwise I think we'll need to use #ifdef.