Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add a new panel configuration for Kodama ......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34505/9/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_kodama.c:
https://review.coreboot.org/c/coreboot/+/34505/9/src/mainboard/google/kukui/... PS9, Line 16: #include <console/console.h> : #include <console/console.h> : #include <delay.h> : #include <device/device.h> : #include <edid.h> : #include <gpio.h> : #include <soc/auxadc.h> : #include <soc/dsi.h> : #include <soc/gpio.h> : #include <boardid.h> : : #include "gpio.h" You don't need all these include. Just
#include "panel.h"
https://review.coreboot.org/c/coreboot/+/34505/9/src/mainboard/google/kukui/... PS9, Line 343: // [0] = &AUO_??? is not ready remove this if it's not ready.