Amol N Sukerkar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33844 )
Change subject: src/security/vboot: Add option to skip display init with vboot 2.0
......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/33844/1/src/security/vboot/Kconfig
File src/security/vboot/Kconfig:
https://review.coreboot.org/#/c/33844/1/src/security/vboot/Kconfig@172
PS1, Line 172: config VBOOT_MUST_REQUEST_DISPLAY
nit: maybe move it right above this option because they're related to the same thing
Ack
https://review.coreboot.org/#/c/33844/1/src/security/vboot/Kconfig@177
PS1, Line 177: Set this option to indicate to vboot that this platform will skip its
Should update this text to clarify this only happens when MAY_SKIP_DISPLAY_INIT is set. […]
Ack
https://review.coreboot.org/#/c/33844/1/src/security/vboot/Kconfig@244
PS1, Line 244: CHROMEOS
The option isn't really CHROMEOS specific so this text shouldn't mention it -- it makes sense for an […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33844
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icadad6da34dcb817af02868e89a94ea62dbfa7b3
Gerrit-Change-Number: 33844
Gerrit-PatchSet: 2
Gerrit-Owner: Amol N Sukerkar
amol.n.sukerkar@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Amol N Sukerkar
amol.n.sukerkar@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Sachin Agrawal
sachin.agrawal@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Joel Kitching
kitching@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Comment-Date: Fri, 28 Jun 2019 22:58:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment