Hello Patrick Rudolph, Angel Pons, Arthur Heymans, Matt DeVillier, Paul Menzel, build bot (Jenkins), Nico Huber, Martin Roth, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31382
to look at the new patch set (#3).
Change subject: ec/quanta/it8518: Use ACPI EC code ......................................................................
ec/quanta/it8518: Use ACPI EC code
ec/quanta/it8518 contains code for reading and writing the EC. lenovo/x131e uses the Quanta IT8518, but with the H8 EC code in coreboot. To mix includes from ec/quanta/it8518 with code from H8, drop duplicate functions and definitions from quanta/it8518 and use code from ec/acpi instead.
Also fix a bad constant MBAT_STATUS.
Change-Id: I7bea7445f34817cef1602843bbded59230bb8d47 Signed-off-by: James Ye jye836@gmail.com --- M src/ec/quanta/it8518/Kconfig M src/ec/quanta/it8518/ec.c M src/ec/quanta/it8518/ec.h M src/mainboard/google/stout/chromeos.c M src/mainboard/google/stout/early_init.c M src/mainboard/google/stout/ec.c M src/mainboard/google/stout/mainboard.c M src/mainboard/google/stout/mainboard_smi.c 8 files changed, 17 insertions(+), 59 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/31382/3