[coreboot-gerrit] [S] Change in coreboot[main]: cpu/x86/smm/smm_module_loader.c: Pass full SMRAM region info to SMM r...

[Shuo Liu (Code Review)]

Attention is currently required from: Angel Pons, Arthur Heymans, Benjamin Doron, Christian Walter, Felix Held, Fred Reitberger, Jason Glenesk, Jeff Daly, Johnny Lin, Lean Sheng Tan, Matt DeVillier, Tim Chu, Vanessa Eusebio.

Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80703?usp=email )

Change subject: cpu/x86/smm/smm_module_loader.c: Pass full SMRAM region info to SMM runtime
......................................................................

Patch Set 2:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/80703/comment/57573be1_39bed7ca :
PS2, Line 17: integrity of the S3 resume path.
> smm_region_overlaps_handler() consumes these fields. […]

Sorry, I mean the current smm_region_overlaps_handler() only provides SMRAM, but not staging cache and chip-specific area. If we would like to provide the latter two, we need another patch to cover. Hence, for the commit message of this, we need to be specific, e.g.,

cpu/x86/smm: Pass full SMRAM region info to SMM runtime

This data is used by smm_region_overlaps_handler(). Callers use this
helper to determine if it's safe to read/write to memory buffers taken
from untrusted input. coreboot SMI handlers must not be confused into
writing over any SMRAM, not just the code subregion.