Attention is currently required from: Angel Pons, Arthur Heymans, Christian Walter, Jincheng Li, Lean Sheng Tan, Mark Chang, Patrick Rudolph.
yuchi.chen@intel.com has posted comments on this change by Mark Chang. ( https://review.coreboot.org/c/coreboot/+/85532?usp=email )
Change subject: Add support for MiTAC Computing Whitestone-2 mainboard
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/mitaccomputing/whitestone-2/bootblock.c:
https://review.coreboot.org/c/coreboot/+/85532/comment/dc44b3b2_170f522f?usp... :
PS1, Line 18: static void enable_espi_lpc_io_windows(void)
Is is possible to use the lpc functions in `src/soc/intel/common/block/lpc/lpc_lib.c`?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85532?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icf625cf8e9c76ef08411614c15ee43d0c459b905
Gerrit-Change-Number: 85532
Gerrit-PatchSet: 1
Gerrit-Owner: Mark Chang
mark.chang@mitaccomputing.com
Gerrit-Reviewer: Angel Pons
angel.pons@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jincheng Li
jincheng.li@intel.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: yuchi.chen@intel.com
Gerrit-Attention: Mark Chang
mark.chang@mitaccomputing.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Jincheng Li
jincheng.li@intel.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Angel Pons
angel.pons@9elements.com
Gerrit-Comment-Date: Mon, 09 Dec 2024 07:24:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No