22 Jul
2020
22 Jul
'20
5:59 p.m.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43718 )
Change subject: ec/system76: Add console support ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43718/3/src/ec/system76/ec/system76... File src/ec/system76/ec/system76_ec.c:
https://review.coreboot.org/c/coreboot/+/43718/3/src/ec/system76/ec/system76... PS3, Line 7: // This is the command region for System76 EC firmware. It must be : // enabled for LPC in the mainboard. : use /* comment style? (it's not a *must* according to coreboot style guide but it's what is normally used)
--
To view, visit https://review.coreboot.org/c/coreboot/+/43718
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I861bf3e22f40dd6c3ec7ba1d73711b399358e332
Gerrit-Change-Number: 43718
Gerrit-PatchSet: 3
Gerrit-Owner: Jeremy Soller jeremy@system76.com
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 22 Jul 2020 20:59:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment