[coreboot-gerrit] Change in coreboot[master]: arch/x86: Implement RESET_VECTOR_IN_RAM

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35035 )

Change subject: arch/x86: Implement RESET_VECTOR_IN_RAM
......................................................................

Patch Set 15:

(2 comments)

https://review.coreboot.org/c/coreboot/+/35035/15/Makefile.inc 
File Makefile.inc:

https://review.coreboot.org/c/coreboot/+/35035/15/Makefile.inc@1162 
PS15, Line 1162: # Ignore segments for .car.data or .earlyram.data while adding romstage.
Isn't an empty .data already asserted by the linker scripts? Aaron has made some suggestions to add .data to remaining stages but I don't know if that is pushed for review yet.

https://review.coreboot.org/c/coreboot/+/35035/15/src/arch/x86/memlayout.ld 
File src/arch/x86/memlayout.ld:

https://review.coreboot.org/c/coreboot/+/35035/15/src/arch/x86/memlayout.ld@... 
PS15, Line 66: #if !CONFIG(RESET_VECTOR_IN_RAM)
The linker script alone does not add anything in .id section so I don't immediately see the need for the quard.