Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/50099 )
Change subject: mb/google/dedede/var/magolor: Configure Acoustic noise mitigation UPDs ......................................................................
mb/google/dedede/var/magolor: Configure Acoustic noise mitigation UPDs
Enable Acoustic noise mitigation for magolor and set slew rate to 1/8 which is calibrated value for the board.
BUG=b:178678267 BRANCH=dedede TEST=build firmware to UPD and Acoustic noise test
Signed-off-by: Ren Kuo ren.kuo@quanta.corp-partner.google.com Change-Id: Idea2a801399bb5c7e0b8e59ee7a826c86a44f4ea Reviewed-on: https://review.coreboot.org/c/coreboot/+/50099 Reviewed-by: Karthik Ramasubramanian kramasub@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/dedede/variants/magolor/overridetree.cb 1 file changed, 6 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Ren Kuo: Looks good to me, but someone else must approve Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/dedede/variants/magolor/overridetree.cb b/src/mainboard/google/dedede/variants/magolor/overridetree.cb index 78d5dde..23932c3 100644 --- a/src/mainboard/google/dedede/variants/magolor/overridetree.cb +++ b/src/mainboard/google/dedede/variants/magolor/overridetree.cb @@ -71,6 +71,12 @@
register "tcc_offset" = "15" # TCC of 90C
+ # Enable Acoustic noise mitigation and set slew rate to 1/8 + # Rest of the parameters are 0 by default. + register "AcousticNoiseMitigation" = "1" + register "SlowSlewRate" = "SlewRateFastBy8" + register "FastPkgCRampDisable" = "1" + device domain 0 on device pci 04.0 on chip drivers/intel/dptf