Attention is currently required from: Felix Held, Julius Werner, Marshall Dawson, Maximilian Brune, Zheng Bao, ritul guru.
Bao Zheng has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/84533?usp=email )
Change subject: amdfwtool: Move ISH before PSP L2
......................................................................
Patch Set 12:
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/84533/comment/dd7d3bf6_91238841?usp... :
PS12, Line 972: if (!cb_config->combo_new_rab || ctx->combo_index == 0) {
: pspdir = new_psp_dir(ctx, cb_config->multi_level, cookie);
: ctx->pspdir = pspdir;
: if (recovery_ab)
: ctx->pspdir_bak = new_psp_dir(ctx, cb_config->multi_level, cookie);
: }
: /* The ISH tables are with PSP L1. */
: if (cb_config->need_ish && ctx->ish_a_dir == NULL) /* Need ISH */
: ctx->ish_a_dir = new_ish_dir(ctx);
: if (cb_config->need_ish && ctx->ish_b_dir == NULL) /* Need ISH */
: ctx->ish_b_dir = new_ish_dir(ctx);
For the family older than mendocino, it uses the old combo definition. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84533?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id69268619893d78d9b5330052a4fd5b501263f75
Gerrit-Change-Number: 84533
Gerrit-PatchSet: 12
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ritul guru
ritul.bits@gmail.com
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: ritul guru
ritul.bits@gmail.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 28 Feb 2025 02:04:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bao Zheng
fishbaozi@gmail.com
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com