Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38726 )
Change subject: ec/google/chromeec : Enable TCSS port set flag
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38726/6/src/ec/google/chromeec/ec.c
File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/38726/6/src/ec/google/chromeec/ec.c...
PS6, Line 1482: EC_CMD_USB_PD_SET_TCSS_STATE
Would be nice to have EC_CMD_USB_PD_SET_EARLY_TCSS_STATE
I used the same name as the ec version of ec_commands.h for parity
https://review.coreboot.org/c/coreboot/+/38726/6/src/ec/google/chromeec/ec.c...
PS6, Line 1493: if (rv)
: return rv;
return google_chromeec_command(&cmd);
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38726
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idfc1e6515411fab75b7da1b60775c26d17089c1c
Gerrit-Change-Number: 38726
Gerrit-PatchSet: 7
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Divya Sasidharan
divya.s.sasidharan@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Vijay P Hiremath
vijay.p.hiremath@intel.com
Gerrit-Comment-Date: Fri, 07 Feb 2020 19:25:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Divya Sasidharan
divya.s.sasidharan@intel.corp-partner.google.com
Comment-In-Reply-To: Vijay P Hiremath
vijay.p.hiremath@intel.com
Gerrit-MessageType: comment