Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41853 )
Change subject: mb/google/dedede: Default spk_en gpio to low ......................................................................
mb/google/dedede: Default spk_en gpio to low
The max98357a_platform_driver will turn on/off the speaker enable gpio based on use, so configure it low to save power.
BUG=None TEST=Built dedede and tested speaker playback working. We are seeing a power saving of ~10mW.
Change-Id: I070679457b06cb82633c1197b893a5d89c8b2cf0 Signed-off-by: Usha P usha.p@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41853 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com Reviewed-by: Ronak Kanabar ronak.kanabar@intel.com --- M src/mainboard/google/dedede/variants/baseboard/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved Ronak Kanabar: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/dedede/variants/baseboard/gpio.c b/src/mainboard/google/dedede/variants/baseboard/gpio.c index e62140e..71c0c14 100644 --- a/src/mainboard/google/dedede/variants/baseboard/gpio.c +++ b/src/mainboard/google/dedede/variants/baseboard/gpio.c @@ -175,7 +175,7 @@ /* D16 : HP_INT_ODL */ PAD_CFG_GPI_INT(GPP_D16, NONE, PLTRST, EDGE_BOTH), /* D17 : EN_SPK */ - PAD_CFG_GPO(GPP_D17, 1, PLTRST), + PAD_CFG_GPO(GPP_D17, 0, PLTRST), /* D18 : I2S_MCLK */ PAD_CFG_NF(GPP_D18, NONE, DEEP, NF1), /* D19 : WWAN_WLAN_COEX1 */