Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45459 )
Change subject: lib/spd: respect spd memory part name override ......................................................................
Patch Set 58:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45459/58/src/include/spd_bin.h File src/include/spd_bin.h:
https://review.coreboot.org/c/coreboot/+/45459/58/src/include/spd_bin.h@45 PS58, Line 45: const This is a completely unrelated change and unnecessarily results in touching all the SoC files. If this change is required, it should be done in a CL of its own.
https://review.coreboot.org/c/coreboot/+/45459/58/src/lib/spd_bin.c File src/lib/spd_bin.c:
https://review.coreboot.org/c/coreboot/+/45459/58/src/lib/spd_bin.c@147 PS58, Line 147: size_t *len) nit: This will fit on the previous line within the 96-column limit.