Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49187 )
Change subject: soc/intel/jasperlake: Update acoustic noise related parameters ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/49187/1/src/soc/intel/jasperlake/fs... File src/soc/intel/jasperlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/49187/1/src/soc/intel/jasperlake/fs... PS1, Line 244: 0 For which VR domain is this? Why is the assumption here that the mainboard setting is for VR domain-0 only? Please see TGL as an example of how this is setup for other platforms: https://review.coreboot.org/cgit/coreboot.git/tree/src/soc/intel/tigerlake/c...