Attention is currently required from: Jason Glenesk, Martin Roth, Marshall Dawson, Mathew King.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50208 )
Change subject: mb/amd/majolica: add fmd sections to build chromeos bootimage
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I understand and this seemed to be the quickest way to build majolica firmware with chromeos infrast […]
maybe leave the board.fmd as it is right now and add a chromeos.fmd file that contains everything you'll need and add the following to the board's Kconfig file:
config FMDFILE
string
default "src/mainboard/amd/majolica/chromeos.fmd" if CHROMEOS
default "src/mainboard/amd/majolica/board.fmd"
that would keep the default without any chromeos/vboot specific things but would still allow you to test chromeos/vboot things against majolica
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50208
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5eb3c60fe60e4029485fae642c88c5c013ffb3f6
Gerrit-Change-Number: 50208
Gerrit-PatchSet: 1
Gerrit-Owner: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Mathew King
mathewk@chromium.org
Gerrit-Comment-Date: Tue, 02 Feb 2021 18:13:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mathew King
mathewk@chromium.org
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment