Attention is currently required from: Intel coreboot Reviewers, Johannes Hahn, Uwe Poeche, Werner Zeh.
Mario Scheithauer has posted comments on this change by Johannes Hahn. ( https://review.coreboot.org/c/coreboot/+/86068?usp=email )
Change subject: soc/intel/elkhartlake/fsp_params.c: Adjust PchLegacyIoLowLatency param
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86068/comment/d03acc07_188123aa?usp... :
PS1, Line 7: soc/intel/elkhartlake/fsp_params.c:
soc/intel/ehl/fsp_params:
makes it a bit shorter, but it's up to you
https://review.coreboot.org/c/coreboot/+/86068/comment/85a8a051_035970b9?usp... :
PS1, Line 12: == 0
I think you can leave that out.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86068?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I009cc10fee1f2cf2e2d7e6329cf98d2f95ea77b5
Gerrit-Change-Number: 86068
Gerrit-PatchSet: 1
Gerrit-Owner: Johannes Hahn
johannes-hahn@siemens.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Uwe Poeche
uwe.poeche@siemens.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Uwe Poeche
uwe.poeche@siemens.com
Gerrit-Attention: Johannes Hahn
johannes-hahn@siemens.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Mon, 20 Jan 2025 13:26:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes