[coreboot-gerrit] Change in coreboot[master]: sb/amd/cimx: replace cimx_util with common ACPIMMIO AMD block

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37328 )

Change subject: sb/amd/cimx: replace cimx_util with common ACPIMMIO AMD block
......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/c/coreboot/+/37328/1/src/mainboard/pcengines/apu... 
File src/mainboard/pcengines/apu1/gpio_ftns.c:

https://review.coreboot.org/c/coreboot/+/37328/1/src/mainboard/pcengines/apu... 
PS1, Line 28: 	return (base_addr);
> () not needed

Done

https://review.coreboot.org/c/coreboot/+/37328/1/src/mainboard/pcengines/apu... 
File src/mainboard/pcengines/apu2/gpio_ftns.c:

https://review.coreboot.org/c/coreboot/+/37328/1/src/mainboard/pcengines/apu... 
PS1, Line 25: 	bdata = read32((const volatile void *)(ACPI_MMIO_BASE + GPIO_OFFSET
> OT: Looks like a candidate followup for some of the new ACPIMMIO functions. […]

Ack