Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34328 )
Change subject: soc/intel: Use config_of() ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34328/1/src/soc/intel/baytrail/roms... File src/soc/intel/baytrail/romstage/pmc.c:
https://review.coreboot.org/c/coreboot/+/34328/1/src/soc/intel/baytrail/roms... PS1, Line 50: if (dev)
not required any more since config_of already checks for dev != NULL
Done
https://review.coreboot.org/c/coreboot/+/34328/1/src/soc/intel/cannonlake/pm... File src/soc/intel/cannonlake/pmutil.c:
https://review.coreboot.org/c/coreboot/+/34328/1/src/soc/intel/cannonlake/pm... PS1, Line 178: PCH_DEVFN_PMC
This will have to be changed to SA_DEVFN_ROOT
Done
https://review.coreboot.org/c/coreboot/+/34328/1/src/soc/intel/icelake/pmuti... File src/soc/intel/icelake/pmutil.c:
https://review.coreboot.org/c/coreboot/+/34328/1/src/soc/intel/icelake/pmuti... PS1, Line 177: PCH_DEVFN_PMC
To be dealt with in CB:34327
Done
https://review.coreboot.org/c/coreboot/+/34328/1/src/soc/intel/skylake/final... File src/soc/intel/skylake/finalize.c:
https://review.coreboot.org/c/coreboot/+/34328/1/src/soc/intel/skylake/final... PS1, Line 134: PCH_DEV_PMC
Yes, but out of scope.
Done