Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30855 )
Change subject: arch/x86: Align _start16bit with C_ENVIRONMENT_BOOBLOCK ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/30855/2/src/cpu/x86/16bit/entry16.inc File src/cpu/x86/16bit/entry16.inc:
https://review.coreboot.org/#/c/30855/2/src/cpu/x86/16bit/entry16.inc@32 PS2, Line 32: #if IS_ENABLED(CONFIG_C_ENVIRONMENT_BOOTBLOCK) || \ Presumably this works because _start16bit is < 2^11 away from reset vector? This symbol needs to be tightly coupled with reset16.inc. I'm guessing we just get lucky in our #includes that everything gets thrown in the same section in bootblock_crt0.S. We probably should be more explicit in what sections everything lives in, but I'd also like to see symbol dump with this CL to compare if we're wasting space between here and reset vector.