[coreboot-gerrit] Change in coreboot[master]: soc/intel: Expand SA_DEV_ROOT for ramstage

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34411 )

Change subject: soc/intel: Expand SA_DEV_ROOT for ramstage
......................................................................

Patch Set 2:

(1 comment)
> Patch Set 2:
>
> (1 comment)

https://review.coreboot.org/c/coreboot/+/34411/2/src/soc/intel/skylake/inclu... 
File src/soc/intel/skylake/include/soc/pci_devs.h:

https://review.coreboot.org/c/coreboot/+/34411/2/src/soc/intel/skylake/inclu... 
PS2, Line 35: SA_DEV_ROOT
> > Still used pre-ram, maybe smm. […]

Yes, well config data is already dynamic e.g. google/nami variant_devtree_update().

Maybe config_of_XX() should always return const struct, and we require explicit casts where ramstage wants to modify config data? That way we would keep some track of the fields that would fail in smm.

TBH: I would rather remove devicetree from smm entirely but did not check why we have it.