build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31270 )
Change subject: intel/spi: Define PCI accessor aliases only once
......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/#/c/31270/4/src/include/device/pci_compat.h
File src/include/device/pci_compat.h:
https://review.coreboot.org/#/c/31270/4/src/include/device/pci_compat.h@20
PS4, Line 20: #define pci_read_config_byte(dev, reg, targ)\
Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/31270/4/src/include/device/pci_compat.h@22
PS4, Line 22: #define pci_read_config_word(dev, reg, targ)\
Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/31270/4/src/include/device/pci_compat.h@24
PS4, Line 24: #define pci_read_config_dword(dev, reg, targ)\
Macros with complex values should be enclosed in parentheses
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31270
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If7190ac105b2a65a9576709955c3cc840b95dcdf
Gerrit-Change-Number: 31270
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Guckian
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: York Yang
york.yang@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 10 Feb 2019 11:18:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment