Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40540 )
Change subject: mb/google/volteer: use the new generic SPDs
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40540/5/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/volteer/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/40540/5/src/mainboard/google/voltee...
PS5, Line 10: QDP
Done
Angel, that's a good suggestion, but there's not a way to encapsulate that information in the file itself. I'm creating a document that tracks that information, perhaps I should check something similar into mainboard/google/volteer/spd/ that contains this information.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40540
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3608968ce62c615645941d8e141a8df4cb9b41a8
Gerrit-Change-Number: 40540
Gerrit-PatchSet: 11
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jes Klinke
jbk@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 07 May 2020 17:52:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment