Jeremy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37660 )
Change subject: ifwitool: Introduce a use the Second Logical Boot Partition option ......................................................................
Patch Set 7:
(3 comments)
All done.
https://review.coreboot.org/c/coreboot/+/37660/6/util/cbfstool/ifwitool.c File util/cbfstool/ifwitool.c:
https://review.coreboot.org/c/coreboot/+/37660/6/util/cbfstool/ifwitool.c@89... PS6, Line 890: buffer_get(buff) + offset
nit: (uintptr_t)data + offset?
Done
https://review.coreboot.org/c/coreboot/+/37660/6/util/cbfstool/ifwitool.c@89... PS6, Line 897: !
nit: ... for LBP=%zd\n", param. […]
Done
https://review.coreboot.org/c/coreboot/+/37660/6/util/cbfstool/ifwitool.c@19... PS6, Line 1960: 1
nit: Can you add LBP1 and LBP2 macros and use those instead of 0/1? Also, param. […]
Done