Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44037 )
Change subject: sconfig: Allow chipset to provide a base devicetree ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44037/9/util/sconfig/main.c File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/44037/9/util/sconfig/main.c@1762 PS9, Line 1762: base_root_bus
Shouldn't this be chipset_root_bus?
it has to be base_root_bus as the initial because that is where the devices first get added, this ties in with the comment below.
https://review.coreboot.org/c/coreboot/+/44037/9/util/sconfig/main.c@1763 PS9, Line 1763: parse_override_devicetree
I think we need to update this function as well to pass in the base root bus that is actually being […]
the chipset device tree doesn't exist for most soc (or even non-soc for the older stuff using north/south layout) so it has to be treated special. when it does exist those devices actually get added to the 'base' root bus first and then overridden. so the naming is actually off in what it does because of the way the parser adds devices.