Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45256 )
Change subject: soc/intel/tigerlake: Clean up systemagent.h
......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45256/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45256/1//COMMIT_MSG@7
PS1, Line 7: soc/intel/tigerlake: Maintain consistent tab in systemagent.h
I would use: […]
Ack
https://review.coreboot.org/c/coreboot/+/45256/1//COMMIT_MSG@10
PS1, Line 10: This patch converts
Convert
Ack
https://review.coreboot.org/c/coreboot/+/45256/1//COMMIT_MSG@11
PS1, Line 11: Combine
Group together
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45256
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I82fc362589389081b1b1856524a972b780af9a13
Gerrit-Change-Number: 45256
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Comment-Date: Thu, 10 Sep 2020 13:12:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment