Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47165 )
Change subject: sb/intel/*: Use common code to configure the POST code ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/47165/2/src/southbridge/intel/i8280... File src/southbridge/intel/i82801ix/Kconfig:
https://review.coreboot.org/c/coreboot/+/47165/2/src/southbridge/intel/i8280... PS2, Line 23: select SOUTHBRIDGE_INTEL_COMMON_POST ouch. I guess it's been added here because the other options aren't sorted
https://review.coreboot.org/c/coreboot/+/47165/2/src/southbridge/intel/ibexp... File src/southbridge/intel/ibexpeak/bootblock.c:
https://review.coreboot.org/c/coreboot/+/47165/2/src/southbridge/intel/ibexp... PS2, Line 80: the call is now missing from ibexpeak?